Re: Jabber Server?

[Adrian Reber <adrian lisas de>]

On Thu, Mar 24, 2005 at 02:24:44PM +0100, Enrico Scholz wrote:
> * '-p' should be used with %install
> 
> * /usr/bin/c2s is packaged SUID root... is this really needed, especially
>   because gcc4 gives out a lot of warnings and the code is not trivial
> 
> * the initscript starts 5 daemons; when jabber allows to use only a
>   subset of them on one machine, there should exist a way to disable
>   startup of some daemons. Generally, I would prefer one initscript per
>   service.
> 
> * the programs are linked against libraries with redundant functionality
>   (mysql vs. pgsql, perhaps ldap). I would prefer either subpackages with
>   minimal binaries (e.g. -mysql, -pgsql, -ldap), or at least, that unneeded
>   functionality can be disabled at build-time. E.g. when writing
> 
>   | %{!?_without_ldap:BuildRequires: openldap-devel}
>   | ...
>   | %{!?_without_ldap:--enable-ldap}%{?_without_ldap:--disable-ldap}

I am ready for another review. The only thing from this list I have not
changed is the SUID binary because I need it so that it works with pam
authentication.

		Adrian