[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: make tag and %{?dist}



On Wed, 2005-05-04 at 09:17 -0500, Josh Boyer wrote:
> On Wed, May 04, 2005 at 09:08:41AM -0500, Tom 'spot' Callaway wrote:
> > On Wed, 2005-05-04 at 09:58 -0400, Ignacio Vazquez-Abrams wrote:
> > > On Wed, 2005-05-04 at 08:43 -0500, Tom 'spot' Callaway wrote:
> > > > In the spec, as the first two lines, you should put:
> > > > 
> > > > %define dist .fc3
> > > > %define fedora 3
> > > 
> > > What about:
> > > 
> > > %{!?dist: %define dist .fc3 }
> > > %{!?fedora: %define fedora 3 }
> > 
> > Nothing's defining %dist or %fedora in the buildsystem, so this is
> > unnecessary. Although, if you're importing a package from an outside
> > repo (where the buildsystem is defining these macros), then that might
> > be necessary.
> 
> Ok, the fact that the buildsystem wasn't defining those macros had escaped me.
> Mind if I explicitly point that out on the Wiki?

The wiki page needs a complete rewrite. I put this on the top of it:

NOTE! These guidelines need to be rewritten. You should ignore them for
the time being.

But apparently, it wasn't big or bold enough. :)

~spot
-- 
Tom "spot" Callaway: Red Hat Sales Engineer || GPG Fingerprint: 93054260
Fedora Extras Steering Committee Member (RPM Standards and Practices)
Aurora Linux Project Leader: http://auroralinux.org
Lemurs, llamas, and sparcs, oh my!


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]