[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: python-logilab-common



On Wed, 2005-05-04 at 16:27 -0400, Konstantin Ryabitsev wrote:
> On 5/4/05, Brian Pepple <bdpepple ameritech net> wrote:
> > I'll be willing to co-sponsor your package.  Give me a chance to look it
> > over, and I'll send an official follow-up later this evening.
> 
> http://phy.duke.edu/~icon/misc/fedora-extras/

MD5Sums:
27d1c71e5ff8eef0a5c2e957c80311cc  python-logilab-common-0.9.3-2.src.rpm
bfbe68606f2448b58836fb79b2582e71  common-0.9.3.tar.gz
2c658acf746a3d7c256ff949ced2449e  python-logilab-common.spec

Good:
* Verified license - GPL.
* Upstream source tarball verified
* Package name conforms to the Fedora Naming Guidelines
* All necessary BuildRequires listed.
* Package rebuilds as non-root user
* Rpmlint does not find problems

Needs Work:
One thing I noticed right off the bat with both of your specs, is that
when you are removing files, your using $RPM_BUILD_ROOT/%
{_python_sitelib} instead of $RPM_BUILD_ROOT%{_python_sitelib}.  This
should show up in your build logs as:

+ rm -rf /var/tmp/python-logilab-common-0.9.3-2-root-
machbuild//usr/lib/python2.4/site-packages/logilab/common/test

After this is corrected, the python-logilab-common package can be
imported into CVS.

/B
-- 
Brian Pepple <bdpepple ameritech net>

gpg --keyserver pgp.mit.edu --recv-keys 810CC15E
BD5E 6F9E 8688 E668 8F5B  CBDE 326A E936 810C C15E

Attachment: signature.asc
Description: This is a digitally signed message part


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]