[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: New Package: Loudmouth



-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Brian Pepple wrote:
> On Sun, 2005-05-01 at 19:47 +0000, Brian Pepple wrote:
> 
>>
>>Loudmouth: C library for programming with the Jabber protocol.
>>http://piedmont.homelinux.org/fedora/gossip/loudmouth.spec
>>http://piedmont.homelinux.org/fedora/gossip/loudmouth-0.17.2-1.src.rpm
> 
> 
> Anyone?

Good:

- - MD5sums:
    db5dd069f3c7de18d5347ebaaee4ad61  loudmouth-0.17.2.tar.bz2
    ba8a10bc6c5f6034df7816cccfa96a63  loudmouth-0.17.2-1.src.rpm
- - License is LGPL
- - Upstream tarball verified
- - Naming guidelines
- - rpmlint ok

Nitpicks:

- - mach builds it for FC-devel, but on FC3 it compiles without SSL. It
looks like it needs

%if %{with_ssl}
BuildRequires: libgcrypt-devel
%endif

- - replace %{_prefix}/include with %{_includedir}

- - I noticed very few spec files in Extras include
  Requires(post):   /sbin/ldconfig
  Requires(postun): /sbin/ldconfig
  Is it considered overkill ?


Overall, i approve this package.

- -denis
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.6 (GNU/Linux)
Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org

iD8DBQFCebbHN21V2B2op6oRAqt7AJ9yy/ps1kC+PurhP7qddHyFi2MbWgCgir9w
ByVDG7LuhFKP6TABoPtMcS0=
=pcyM
-----END PGP SIGNATURE-----


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]