Re: Review Request: gtorrentviewer

[Michael Schwendt <bugs michael gmx net>]

On Mon, 09 May 2005 18:27:30 +0100, Paul Howarth wrote:

> >>>%{__sed} -i -e 's Exec=gtorrentviewer@Exec=%{_bindir}/gtorrentviewer@' \
> >>>	    -e 's Icon=gtorrentviewer png@Icon=%{_datadir}/pixmaps/gtorrentviewer.png@' \
> >>>	data/gtorrentviewer.desktop.in
> >>
> >>Completely unnecessary.
> > 
> > 
> > Some might say that the latter (Icon= with a hardcoded path) is actually
> > harmful because it'll probably prevent icon theming from working for
> > this particular icon.  Not that it'd be a big deal right now, but in
> > principle.
> 
> I've reverted back to the relative path now. I did the edit to use 
> absolute paths because the NewPackageProcess Wiki page refers to the 
> logjam package as an example, and the desktop file in that package uses 
> absolute paths; I thought it might be a portability thing.

Please ignore the yellow box at the bottom of that Wiki page. It doesn't
belong there.