[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: Approval needed: SCIM



大力亮 wrote:
> Hi,
> I'm thinking of adding the package of SCIM into Extras.
> Could anyone review it and give me an approval?
> 
> You can see it here:
> http://briefcase.yahoo.co.jp/bc/ryo_dairiki/lst?.dir=/
> 
> Please download scim-1.2.2-1.src.rpm.
> 
> Regards,
> Ryo Dairiki <ryo-dairiki mbm nifty com>
> 

NOTE: This is not a complete review.

Please use attached spec patch.
- Never include Packager tag
- Requires not necessary, they will be implicitly Required
- %clean can be simpler

Assuming the sources match upstream, this is good enough, but I'd like
Jens Petersen to do a sanity check since he has experience with this
software.  If someone else is willing to approve it before Jens
Petersen, that is fine too.

Additionally the binaries needlessly contain /usr/lib64 in RPATH when
this is built on x86_64.  This is not a huge problem, but would be nice
to remove.

+ /usr/lib/rpm/check-rpaths /usr/lib/rpm/check-buildroot
ERROR: file '/usr/bin/scim-config-agent' contains a standard rpath
'/usr/lib64' in [/usr/lib64]
ERROR: file '/usr/bin/scim' contains a standard rpath '/usr/lib64' in
[/usr/lib64]
ERROR: file '/usr/lib64/libscim-gtkutils-1.0.so.6.1.1' contains a
standard rpath '/usr/lib64' in [/usr/lib64]
ERROR: file '/usr/lib64/gtk-2.0/immodules/im-scim.so' contains a
standard rpath '/usr/lib64' in [/usr/lib64]
ERROR: file '/usr/lib64/scim-1.0/1.2.0/Config/socket.so' contains a
standard rpath '/usr/lib64' in [/usr/lib64]
ERROR: file '/usr/lib64/scim-1.0/1.2.0/Config/simple.so' contains a
standard rpath '/usr/lib64' in [/usr/lib64]
ERROR: file
'/usr/lib64/scim-1.0/1.2.0/SetupUI/frontend-hotkeys-setup.so' contains a
standard rpath '/usr/lib64' in [/usr/lib64]
ERROR: file '/usr/lib64/scim-1.0/1.2.0/SetupUI/aaa-imengine-setup.so'
contains a standard rpath '/usr/lib64' in [/usr/lib64]
ERROR: file '/usr/lib64/scim-1.0/1.2.0/SetupUI/panel-gtk-setup.so'
contains a standard rpath '/usr/lib64' in [/usr/lib64]
ERROR: file '/usr/lib64/scim-1.0/1.2.0/SetupUI/x11-frontend-setup.so'
contains a standard rpath '/usr/lib64' in [/usr/lib64]
ERROR: file '/usr/lib64/scim-1.0/1.2.0/FrontEnd/x11.so' contains a
standard rpath '/usr/lib64' in [/usr/lib64]
ERROR: file '/usr/lib64/scim-1.0/1.2.0/FrontEnd/socket.so' contains a
standard rpath '/usr/lib64' in [/usr/lib64]
ERROR: file '/usr/lib64/scim-1.0/1.2.0/IMEngine/rawcode.so' contains a
standard rpath '/usr/lib64' in [/usr/lib64]
ERROR: file '/usr/lib64/scim-1.0/1.2.0/IMEngine/socket.so' contains a
standard rpath '/usr/lib64' in [/usr/lib64]
ERROR: file '/usr/lib64/scim-1.0/1.2.0/Helper/setup.so' contains a
standard rpath '/usr/lib64' in [/usr/lib64]
ERROR: file '/usr/lib64/scim-1.0/scim-panel-gtk' contains a standard
rpath '/usr/lib64' in [/usr/lib64]
ERROR: file '/usr/lib64/scim-1.0/scim-helper-launcher' contains a
standard rpath '/usr/lib64' in [/usr/lib64]
ERROR: file '/usr/lib64/scim-1.0/scim-launcher' contains a standard
rpath '/usr/lib64' in [/usr/lib64]
ERROR: file '/usr/lib64/scim-1.0/scim-helper-manager' contains a
standard rpath '/usr/lib64' in [/usr/lib64]
error: Bad exit status from /var/tmp/rpm-tmp.89791 (%install)

--- scim.spec.orig	2005-05-13 21:44:41.000000000 -1000
+++ scim.spec	2005-05-13 21:46:47.000000000 -1000
@@ -1,18 +1,16 @@
 Summary:       Smart Chinese/Common Input Method platform
 Name:            scim
 Version:          1.2.2
-Release:          1%{?dist}
+Release:          2%{?dist}
 License:          LGPL
 Group:            System Environment/Libraries
 URL:              http://scim.freedesktop.org
-Packager:       Ryo Dairiki <ryo-dairiki users sourceforge net>
 BuildRoot:        %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
 
 Source0:        %{name}-%{version}.tar.gz
 Source1:        xinput-scim
 
 PreReq:         /sbin/ldconfig, /bin/sh
-Requires: glib2 >= 2.0.0, gtk2 >= 2.3.5, pango >= 1.0.0, XFree86-libs >= 4.1.0
 BuildRequires:  gtk2-devel >= 2.0.0, pango-devel >= 1.0.0, XFree86-devel >= 4.1.0, pkgconfig >= 0.12, desktop-file-utils
 
 %description
@@ -73,7 +71,7 @@
 
 
 %clean
-[ -n "$RPM_BUILD_ROOT" -a "$RPM_BUILD_ROOT" != / ] && rm -rf $RPM_BUILD_ROOT
+rm -rf $RPM_BUILD_ROOT
 
 %post
 /sbin/ldconfig
@@ -150,6 +148,8 @@
 #--------------------------------------------------
 
 %changelog
+* Fri May 13 2005 Warren Togami <wtogami redhat com> - 1.2.2-2
+- minor spec fixes
 
-* Fri Mar 13 2005 Ryo Dairiki <ryo-dairiki users sourceforge net> - 1.2.2-0.1
+* Fri Mar 13 2005 Ryo Dairiki <ryo-dairiki users sourceforge net> - 1.2.2-1
 - Initial packaging for Fedora Extras.

[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]