Re: Review/Approval needed: mfstools

[Matthias Saou <thias spam spam spam spam spam spam spam egg and spam freshrpms net>]

Tom 'spot' Callaway wrote :

> This package is in CVS and needs review and approval. Its quite small.
> 
> MFS Tools is a set of utilities for TiVo drive upgrades. This includes
> MFS specific backup and restore, as well as MFS volume expansion and
> shrinking.
> 
> No libraries, one binary, and a few symlinks. :)
> 
> Please review, thanks.

Eek!

Simple points :
- Missing zlib-devel, which doesn't bother configure but makes the build
  fail miserably :-/
- You mix spaces and tabs in your spec file headers -> Readability issues
  when using 4 spaces vs. 8 for tabs or vice versa.
- The release fields seems weird, why two 1s in different places?

Now the nasty one : The package contains files with names way too generic!
And the /usr/share/doc/howto.html file should not be there, copy it to the
pwd and include it as %doc instead of installing it to _docdir.

/usr/bin/backup
/usr/bin/restore

These files definitely need to have their name changed... not sure what
it'll break, though.

Matthias

-- 
Clean custom Red Hat Linux rpm packages : http://freshrpms.net/
Fedora Core release 3 (Heidelberg) - Linux kernel 2.6.11-1.27_FC3
Load : 0.50 0.48 0.38