Re: Request for review: replacing cdiff with colordiff

[Matthias Saou <thias spam spam spam spam spam spam spam egg and spam freshrpms net>]

Ville Skyttä wrote :

> I intend to replace the current Extras cdiff package with colordiff,
> http://colordiff.sf.net/ for FC4 and later.

Looks good to me, your spec files are always a pleasure to review :-)

Two things :
- It says it's a wrapper to diff, but you don't require diffutils, is that
  normal?
- The obsoletes should contain the last known version or version-release of
  cdiff, especially since you provide cdiff.

Matthias

-- 
Clean custom Red Hat Linux rpm packages : http://freshrpms.net/
Fedora Core release 3 (Heidelberg) - Linux kernel 2.6.11-1.27_FC3
Load : 0.17 0.97 1.25