[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: Request for review: scrub



Tom 'spot' Callaway wrote :

> Again, a really small package. One binary, a man page, and some docs.
> 
> Please review for approval.

Things to fix :
- Don't strip the binary, or debuginfo package will be useless
- Don't manually gzip the man page, rpm magic does that for you

Things that could be improved :
- Patch for CFLAGS isn't needed, you can just override at make time
- You can use -D with install to have the directory tree created

Attached is a quick patch to change all this ;-)

Matthias

-- 
Clean custom Red Hat Linux rpm packages : http://freshrpms.net/
Fedora Core release 3 (Heidelberg) - Linux kernel 2.6.11-1.27_FC3
Load : 0.72 1.01 1.20

Attachment: scrub.spec.patch
Description: Binary data


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]