[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: Approval sought: mlmmj & mod_security.



On Thu, 19 May 2005 23:52:06 -0400 (EDT). Chris Ricker waffled thusly:

> On Thu, 19 May 2005, Michael Fleming wrote:
> 
> > Hi,
> > 
> > I've had mlmmj (ezmlm-like mailing list manager) in CVS for a few weeks
> > now with some comments regarding the spec and structure, but no reports
> > of failures / blockers etc. It is still pending an approval (prior to my
> > requesting a build)
> 
> - Remove LICENSE from the %doc - it's exactly the same as COPYING

Done - I might pass this comment upstream to Mads, it seems redundant to
have two copies of the license in the tarball :-)

> - You might want to change
> 
> %dir %{_datadir}/mlmmj/
> %{_datadir}/mlmmj/*
> 
> to
> 
> %{_datadir}/mlmmj
> 
> (does the same thing, but is simpler)

Agreed. I probably did that when I first started packaging it to ensure the
directory and it's contents are both owned by the package. The single entry
is cleaner, mind you so changed it is. :-)

> Other than those two, I don't see any blockers -- source matches
> upstream, spec looks fine and meets all the guidelines, and rpmlint is
> happy. Change the above and it's approved

Done and checked into CVS. Thanks Chris.

Cheers,
Michael.

-- 
Michael Fleming <mfleming enlartenment com>
"Bother" said the Borg, "We've assimilated Pooh!"


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]