[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

RE: New package: rblcheck



Paul Howarth wrote:

[ ... ]
> Unfortunately the comment in the changelog says you added 
> xml.spamhaus.org rather than xbl.spamhaus.org (actual 
> rblcheckrc is OK).

Fixed.

[ ... ]
> 127.0.0.2 not listed by relay.ordb.org
> 
> - relay.ordb.org is a typo for relays.ordb.org (already included)
>
> 127.0.0.2 not listed by blackhole.compu.net
> 
> - blackhole.compu.net is a non-existent domain

Removed.

[ ... ]

> 127.0.0.2 not listed by blackholes.wirehub.net
> 
> - blackholes.wirehub.net is a non-existent domain

Removed.
 
[ ... ]
> 127.0.0.2 not listed by bl.reynolds.net.au
> 
> - please see http://bl.reynolds.net.au/
> - you probably want to replace this with lists from 
> http://dnsbl.net.au/types/

Removed. Added. t{1,2,3}.dnsbl.net.au

[ ... ]

> 127.0.0.2 not listed by dynablock.wirehub.net
> 
> - dynablock.wirehub.net is a non-existent domain

Removed.

[ ... ]

> 127.0.0.2 not listed by http.opm.blitzed.org
> 
> - http.opm.blitzed.org is a non-existent domain

Removed.
 
[ ... ]

> 127.0.0.2 not listed by pm0-no-more.compu.net
> 
> - pm0-no-more.compu.net is a non-existent domain

Removed.
 
> 127.0.0.2 not listed by relays.visi.com
> 
> - relays.visi.com is a non-existent domain
> 
> 127.0.0.2 not listed by socks.opm.blitzed.org
> 
> - socks.opm.blitzed.org is a non-existent domain

Removed.

[ ... ]

[ ... ]
>
http://filelister.linux-kernel.at/mod_perl?current=/packages/FC_EXTRAS_APPRO
VAL/rblcheck
> > 
> > And once again updated. Release 6.

http://t.linux-kernel.at/s.pl?4a
(shortlink)

Next run: Rel 7.

> You might want to add a DistTag to the release id - see:
> http://fedoraproject.org/wiki/DistTag

I wanted to add it as soon as it has been approven, but OK I added it now.

> BuildRoot: isn't the standard one advocated in the packaging 
> guidelines
> (http://fedoraproject.org/wiki/PackagingGuidelines):
> %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)

Fixed.

> Package builds OK as non-root user.
> 
> rpmlint errors:
> 
> rpmlint -iv rblcheck-1.5-6*
[ ... ]
> The directory permission errors are probably due to my user 
> account being in a SGID directory, and the installer copying 
> the directory permissions. You can fix this by adding:
> 
> %{_bindir}/find . -type d -exec chmod 755 {} \;
[ ... ]
Didn't add this as my linting doesn't mention directory permission problems.

[oliver wasser rblcheck]$ make lint
Wrote: /home/oliver/cvs/rpms/rblcheck/rblcheck-1.5-7.src.rpm
rpmlint rblcheck-1.5-7.src.rpm
E: rblcheck no-signature

You may have a look at it again...

Best,
 Oliver


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]