[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: arc & gcc4 -> please review build fix



On Sat, 21 May 2005 11:00:13 +0200, Nicolas Mailhot wrote:

> Hi,
> 
> Anyone with more curent C knowledge than me care to review the arc gcc4 
> fix in https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=156225 ?
> 
> Basically pristine source build fails with :
> 
> marc.c:309: error: incompatible implicit declaration of
> function 'makefnam'
> marc.c:51: error: previous implicit declaration of
> 'makefnam' was here
> 
> and we fix the build with :
> 
> diff -uNr arc-5.21j.orig/marc.c arc-5.21j/marc.c
> --- arc-5.21j.orig/marc.c	2003-10-31 03:22:36.000000000 +0100
> +++ arc-5.21j/marc.c	2005-05-21 10:40:22.000000000 +0200
> @@ -48,7 +48,6 @@
>   int nargs;			       /* number of arguments */
>   char *arg[];			       /* pointers to arguments */
>   {
> -    char *makefnam();		       /* filename fixup routine */
>       char *envfind();
>   #if	!_MTS
>       char *arctemp2, *mktemp();		/* temp file stuff */
> 
> (build fix only - runtime not tested)

Yes, it is right to drop all those declarations, in particular as
makefnam takes arguments of (char*,char*,char*). It's defined in
arcmisc.c.

-- 
Fedora Core release Rawhide (Rawhide) - Linux 2.6.11-1.1323_FC4
loadavg: 1.15 1.18 1.05


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]