Re: request for review: qgo

["Tom 'spot' Callaway" <tcallawa redhat com>]

On Thu, 2005-05-19 at 21:52 -0400, Chris Ricker wrote:
> On Thu, 19 May 2005, Chris Ricker wrote:
> 
> > <http://www.oobleck.net/kaboom/fedora/srpms/qgo-1.0.1-1.src.rpm>
> 
> New rev for review at
> 
> <http://www.oobleck.net/kaboom/fedora/srpms/qgo-1.0.1-2.src.rpm>
> 
> Updated to fix a directory not being owned by the rpm

Review of qgo:

Rpmlint tests:

qgo-1.0.1-2.src.rpm:
E: qgo no-signature

qgo-1.0.1-2.i386.rpm:
E: qgo no-signature

All rpmlint errors can be safely ignored.

Good:

- Source matches upstream
- License OK (GPL), COPYING included in package
- Meets PackageNamingGuidelines
- No missing BuildRequires
- Desktop file properly installed

Approved.

~spot
-- 
Tom "spot" Callaway: Red Hat Sales Engineer || GPG Fingerprint: 93054260
Fedora Extras Steering Committee Member (RPM Standards and Practices)
Aurora Linux Project Leader: http://auroralinux.org
Lemurs, llamas, and sparcs, oh my!