Re: New package: eet

["Tom 'spot' Callaway" <tcallawa redhat com>]

On Fri, 2005-05-20 at 01:17 -0400, Ignacio Vazquez-Abrams wrote:
> eet: A library designed to write an arbitrary set of chunks of data to a
> file
> 
> EET is a tiny library designed to write an arbitary set of chunks of
> data to a file and optionally compress each chunk (very much like a zip
> file) and allow fast random-access reading of the file later on.
> 
> http://fedora.ivazquez.net/files/eet-0.9.10.007-1.fc3.src.rpm

Review of eet:

Rpmlint tests:

eet-0.9.10.007-1.src.rpm:
E: eet no-signature

eet-0.9.10.007-1.i386.rpm:
E: eet executable-in-library-package /usr/bin/eet
E: eet zero-length /usr/share/doc/eet-0.9.10.007/ChangeLog
E: eet zero-length /usr/share/doc/eet-0.9.10.007/NEWS
E: eet no-signature

eet-devel-0.9.10.007-1.i386.rpm
E: eet-devel requires-on-release eet 0.9.10.007-1
W: eet-devel no-major-in-name eet-devel
W: eet-devel no-documentation
E: eet-devel no-signature

No need to include zero-length ChangeLog and NEWS files. All other
rpmlint errors can be ignored.

Good:

- Source matches upstream
- License OK (MIT), COPYING included in package
- Libraries have ldconfig in %post/%postun
- Meets PackageNamingGuidelines
- Meets PackagingGuidelines
- *.la files removed
- No missing BuildRequires (glibc-headers brought in by gcc)

Bad:

- Zero-length ChangeLog and NEWS files in main package.

Fix the really minor blocker, and its approved.

~spot
-- 
Tom "spot" Callaway: Red Hat Sales Engineer || GPG Fingerprint: 93054260
Fedora Extras Steering Committee Member (RPM Standards and Practices)
Aurora Linux Project Leader: http://auroralinux.org
Lemurs, llamas, and sparcs, oh my!