[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: Updated new package : dejavu-fonts-1.10



On Mon, 2005-05-23 at 00:15 +0200, Nicolas Mailhot wrote:
> Source:
> http://mapage.noos.fr/nmailhot/fedora/dejavu-fonts-1.10-1.src.rpm

Review of dejavu-fonts:

Rpmlint checks:

dejavu-fonts-1.10-1.src.rpm:
W: dejavu-fonts invalid-license Redistributable, with restrictions
E: dejavu-fonts no-signature
W: dejavu-fonts strange-permission dejavu-fonts.spec 0600
W: dejavu-fonts strange-permission dejavu-ttf-1.10.tar.gz 0600

dejavu-fonts-1.10-1.noarch.rpm:
W: dejavu-fonts invalid-license Redistributable, with restrictions
E: dejavu-fonts no-signature

All rpmlint errors can be safely ignored.

Good:

- Source matches upstream
- License is ok (Redistributable, with restrictions). This is basically
a BSD license with a naming restriction, but since bitstream-vera-fonts
is in FC, this license is ok. LICENSE included in package.
- scriptlets look ok.
- Meets PackageNamingGuidelines
- Meets PackagingGuidelines

Bad:

- Missing Requires: fontconfig (is there ever a scenario where we don't
want fc-cache to run on %post?)

~spot
-- 
Tom "spot" Callaway: Red Hat Sales Engineer || GPG Fingerprint: 93054260
Fedora Extras Steering Committee Member (RPM Standards and Practices)
Aurora Linux Project Leader: http://auroralinux.org
Lemurs, llamas, and sparcs, oh my!


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]