[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: New package: meanwhile



On Tue, 24 May 2005 09:19:28 -0500, Tom 'spot' Callaway wrote:

> On Mon, 2005-05-23 at 22:15 -0500, Josh Boyer wrote:
> > meanwhile: Lotus Sametime Community Client library
> > 
> > Meanwhile provides the basic Lotus Sametime session functionality along
> > with the core services; Presence Awareness, Instant Messaging, Multi-
> > user Conferencing, Preferences Storage, Identity Resolution, and File
> > Transfer.
> > 
> > Project URL: http://meanwhile.sourceforge.net
> > 
> > SRPM URL: http://jdub.homelinux.org/files/meanwhile/
> > 
> > Meanwhile just provides the core Sametime functionality.  The actual
> > client interface is done via a plugin, called gaim-meanwhile.  This will
> > be packaged in a separate RPM and will be available for review shortly.
> 
> Review of meanwhile:
> 
> rpmlint checks:
> 
> meanwhile-0.4.1-1.src.rpm:
> E: meanwhile description-line-too-long The heart of the Meanwhile
> Project is the Meanwhile library, providing the basic
> E: meanwhile description-line-too-long integration of future service
> handlers such as the user directory and whiteboard
> E: meanwhile no-signature
> W: meanwhile strange-permission meanwhile.spec 0600
> 
> meanwhile-0.4.1-1.i386.rpm:
> E: meanwhile description-line-too-long The heart of the Meanwhile
> Project is the Meanwhile library, providing the basic
> E: meanwhile description-line-too-long integration of future service
> handlers such as the user directory and whiteboard
> E: meanwhile zero-length /usr/share/doc/meanwhile-0.4.1/NEWS
> E: meanwhile no-signature
> 
> meanwhile-devel-0.4.1-1.i386.rpm:
> E: meanwhile-devel requires-on-release meanwhile 0.4.1-1
> W: meanwhile-devel no-major-in-name meanwhile-devel
> W: meanwhile-devel no-documentation
> E: meanwhile-devel no-signature
> 
> No need to have that zero-length NEWS in there. All other rpmlint errors
> can be ignored.

* The "description-line-too-long" ought to be corrected. Keep
the lines under 80 columns. That avoids ugly staircase effects
if no assumption about maximum length of lines or auto-wrapping
(block-text) is made.

* pkg-config file in meanwhile-devel has dependencies, a test like

    $ pkg-config --exists meanwhile && echo "yes"

  fails.

* Header files also include glib headers.

* minimum glib2-devel version is sufficient since at least FC1

* explicit dependency on glib2 is not needed

* %post/%postun scriptlets miss dependency on /sbin/ldconfig,
   change them to -p /sbin/ldconfig (as in patch below) to get
   an automatic dependency

--- meanwhile.spec.orig	2005-05-24 05:15:02.000000000 +0200
+++ meanwhile.spec	2005-05-24 16:27:38.000000000 +0200
@@ -11,22 +11,22 @@
 Source:		http://dl.sf.net/meanwhile/meanwhile-%{version}.tar.gz
 URL:		http://meanwhile.sourceforge.net
 BuildRoot:	%{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
-BuildRequires: glib2-devel >= 2.2
-Requires: glib2 >= 2.2
+BuildRequires:	glib2-devel
 
 %description
-The heart of the Meanwhile Project is the Meanwhile library, providing the basic
-Lotus Sametime session functionality along with the core services; Presence
-Awareness, Instant Messaging, Multi-user Conferencing, Preferences Storage,
-Identity Resolution, and File Transfer. This extensible client interface allows
-additional services to be added to a session at runtime, allowing for simple
-integration of future service handlers such as the user directory and whiteboard
-and screen-sharing.
+The heart of the Meanwhile Project is the Meanwhile library, providing the
+basic Lotus Sametime session functionality along with the core services;
+Presence Awareness, Instant Messaging, Multi-user Conferencing,
+Preferences Storage, Identity Resolution, and File Transfer. This
+extensible client interface allows additional services to be added to a
+session at runtime, allowing for simple integration of future service
+handlers such as the user directory and whiteboard and screen-sharing.
 
 %package devel
 Summary: Header files, libraries and development documentation for %{name}
 Group: Development/Libraries
 Requires: %{name} = %{version}-%{release}
+Requires: glib2-devel
 
 %description devel
 This package contains the header files, static libraries and development
@@ -47,11 +47,9 @@
 %clean
 rm -rf $RPM_BUILD_ROOT
 
-%post
-/sbin/ldconfig 2> /dev/null
+%post -p /sbin/ldconfig
 
-%postun
-/sbin/ldconfig 2> /dev/null
+%postun -p /sbin/ldconfig
 
 %files
 %defattr(-, root, root)


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]