[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: New package: gaim-meanwhile



On Tue, 2005-05-24 at 06:24 -0500, Josh Boyer wrote:
> gaim-meanwhile: Lotus Sametime Community Client plugin for Gaim
> 
> This is a Gaim plugin that uses the meanwhile library to allow users to
> connect to a Sametime server with Gaim.
> 
> Project URL: http://meanwhile.sourceforge.net
> 
> SRPM URL: http://jdub.homelinux.org/files/gaim-meanwhile/
> 
> gaim-meanwhile requires the meanwhile package which was posted for
> review earlier.

Review of gaim-meanwhile:

Rpmlint checks:

gaim-meanwhile-1.2.2-1.src.rpm:
E: gaim-meanwhile no-signature
W: gaim-meanwhile strange-permission gaim-meanwhile.spec 0600

gaim-meanwhile-1.2.2-1.i386.rpm:
E: gaim-meanwhile zero-length /usr/share/doc/gaim-meanwhile-1.2.2/NEWS
E: gaim-meanwhile no-signature

Zero-length NEWS is here too (how unexpected!), but all other rpmlint
errors can be ignored.

Good:

- License OK (GPL), COPYING included in package
- Source matches upstream
- .la files excluded
- No missing BuildRequires
- client module loads in gaim (can't really test, because I don't have a
Sametime server)

Bad:

- Zero-length NEWS file doesn't need to be packaged.
- Generic INSTALL file doesn't need to be packaged.
- Package grabbed dependencies on libglib-2.0.so.0, libmeanwhile.so.0,
but not gaim. You probably want to add Requires: gaim >= 1.2.1.

Again, relatively minor blockers here. Fix and I'll approve.

~spot
-- 
Tom "spot" Callaway: Red Hat Sales Engineer || GPG Fingerprint: 93054260
Fedora Extras Steering Committee Member (RPM Standards and Practices)
Aurora Linux Project Leader: http://auroralinux.org
Lemurs, llamas, and sparcs, oh my!


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]