[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: New package: meanwhile



On Tue, 24 May 2005 09:42:16 -0500, Tom 'spot' Callaway wrote:

> On Tue, 2005-05-24 at 16:34 +0200, Michael Schwendt wrote:
> 
> > * The "description-line-too-long" ought to be corrected. Keep
> > the lines under 80 columns. That avoids ugly staircase effects
> > if no assumption about maximum length of lines or auto-wrapping
> > (block-text) is made.
> 
> I saw that error, but I went and checked the line length in the %
> description, and while they were right at 80, none were longer. I
> checked -qip on the package and it didn't stairstep, so I ignored it.

"right at 80" is not "under 80". ;) It's one character too much.  For
ordinary terminals (or graphical widgets with a similar behaviour), cursor
would wrap into the next line where the linefeed would create an empty
line.

> > * %post/%postun scriptlets miss dependency on /sbin/ldconfig,
> >    change them to -p /sbin/ldconfig (as in patch below) to get
> >    an automatic dependency
> 
> /sbin/ldconfig is in glibc. How exactly will a running system not have
> glibc? Simply by compiling this, it will pull in glibc as a Requires.
> There isn't any need to -p /sbin/ldconfig to achieve the same thing.

I don't consider it a blocker criterion either. It would just be more
correct, as the call of /sbin/ldconfig is explicit, and it's an assumption
that the implicit dependency on glibc also adds /sbin/ldconfig right in
time. Experts on RPM installation ordering might have more info.


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]