Request for Review: exo and Terminal

[Kevin Fenzi]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

>>>>> "Ed" == Ed Hill <ed at eh3.com> writes:

Ed> On Thu, 2005-05-26 at 20:43 -0600, Kevin Fenzi wrote:
>> http://www.scrye.com/~kevin/fedora-extras/exo-0.3.0-1.src.rpm

Ed> Good: * source matches upstream * builds, installs, & works-for-me
Ed> w/ FC3

Ed> Bad: * no signature

Ed> Non-blocker nits: * Can the *.la files be removed?  

Fixed. Removed them. 

Ed> * redundant "/" in %{_datadir}//pygtk/2.0/defs/exo-0.3/exo.defs

Done. Removed. 

new src.rpm up at: 

http://www.scrye.com/~kevin/fedora-extras/exo-0.3.0-1.src.rpm

>> http://www.scrye.com/~kevin/fedora-extras/Terminal-0.2.4-1.src.rpm

Ed> Good: * source matches upstream * builds, installs, & works-for-me
Ed> w/ FC3

Ed> Bad: * no signature E: Terminal zero-length
Ed> /usr/share/doc/Terminal-0.2.4/TODO

Removed it from the spec. 

Ed> Not sure: W: Terminal non-standard-group Applications/X11 W:
Ed> Terminal non-standard-dir-in-usr libexec

Ed> I looked all over the Wiki for instructions concerning the package
Ed> group names and didn't find them.  I thought that there was an
Ed> official list of package group names but perhaps I'm just
Ed> insufficiently caffeinated to find it this morning...  Can someone
Ed> please point it out?

After reading the other responses in the thread I guess: 

User Interface/X

Is the least sucky choice. :) 
I have changed it to that...

new src.rpm at: 

http://www.scrye.com/~kevin/fedora-extras/Terminal-0.2.4-1.src.rpm

Ed> Ed

kevin
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.6 (GNU/Linux)
Comment: Processed by Mailcrypt 3.5.8 <http://mailcrypt.sourceforge.net/>

iD8DBQFCl9py3imCezTjY0ERAlbhAJ4nWqOos49OaopR9xXkSszb30aaKwCgip0z
JN91/Z/vkMCSXtkk5ogLSCU=
=t24g
-----END PGP SIGNATURE-----