Request for review: Enlightenment DR17 + EFL

[John Ellson]

Didier Casse wrote:

>Hi all,
>     I would like to have a review on the  Enlightenment DR17 package
>+ the accompanying Enlightenment Foundation Library packages (EFL).
>  
>
Engage fails to rpmbuild on x86_64

Architure dependency in engage.spec:
****************************************************************
--- engage.spec.old     2005-05-29 05:32:34.000000000 -0400
+++ engage.spec 2005-05-30 10:35:01.000000000 -0400
@@ -44,7 +44,7 @@
 %defattr(-,root,root)
 %{_bindir}/engage
 %{_libdir}/engage*
-%{_libdir}/enlightenment/modules_extra/engage/linux-gnu-i686/*
+%{_libdir}/enlightenment/modules_extra/engage/
 %{_datadir}/engage*
 %doc AUTHORS ChangeLog COPYING README
****************************************************************


Improper setting of $libdir in configure.in:
****************************************************************
--- engage-0.0.9/configure.in.old       2005-05-30 10:19:31.000000000 -0400
+++ engage-0.0.9/configure.in   2005-05-30 10:20:57.000000000 -0400
@@ -39,6 +39,7 @@
   fi
 fi

+if test "x{libdir}" = "xNONE"; then
 if test "x${exec_prefix}" = "xNONE"; then
   if test "x${prefix}" = "xNONE"; then
     libdir="${ac_default_prefix}/lib";
@@ -52,6 +53,7 @@
     libdir="${prefix}/lib";
   fi
 fi
+fi

 dnl Set PACKAGE_DATA_DIR in config.h.
 if test "x${datadir}" = 'x${prefix}/share'; then
****************************************************************