[Bug 174377] Review Request:gst - GNU Smalltalk

[bugzilla redhat com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request:gst - GNU Smalltalk


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=174377


michel salim gmail com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |NEEDINFO
         AssignedTo|gdk redhat com              |michel salim gmail com




------- Additional Comments From michel salim gmail com  2005-11-28 15:07 EST -------
Good:
- rpmlint clean
- tarball matches upstream
- installinfo

Bad:
- Package naming: Upstream name is just smalltalk. Debian has gnu-smalltalk, so
I'd suggest renaming the package to gnu-smalltalk (for clarity: gst brings to
mind gstreamer, not smalltalk; consistency with Debian and to leave room for
other Smalltalk variants)

- BuildRequires on gtk+-devel. This should be gtk2-devel. No need to specify a
minimum version as there are no gtk2 <= 2.0 on any Fedora release.

- gtk2-devel depends on glib2-devel and atk-devel already, you can remove them

- Likewise with tcl-devel and tk-devel. tk-devel depends on tcl-devel already.
They have been at versions >= 8 for a long time so no need to specify a minimum
version

- Want to add paragraph breaks in description? Space out the three paragraphs a bit.

- Use %makeinstall instead of manually doing make DESTDIR=$RPM_BUILD_ROOT install



-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.