[Bug 166191] Review Request: perl-Class-DBI-Pg : Class::DBI extension for PostgreSQL

[bugzilla redhat com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-Class-DBI-Pg : Class::DBI extension for PostgreSQL


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=166191


paul city-fan org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|gdk redhat com              |paul city-fan org
OtherBugsDependingO|163776                      |163778
              nThis|                            |




------- Additional Comments From paul city-fan org  2005-09-02 06:24 EST -------
Review:

- rpmlint clean
- package and spec names OK
- package meets guidelines
- license is same as perl, matches spec
- spec written in English and is legible
- sources match upstream
- package builds OK in mock for FC4 (i386)
- BR's mostly OK
- no locales, libraries, subpackages or pkgconfigs to worry about
- not relocatable
- no directory ownership or permissions issues
- no duplicate files
- %clean section present and correct
- macro usage is consistent
- code, not content
- no large docs
- docs don't affect runtime
- no scriptlets

Needswork:

- redundant BR: perl
- include license text
- add perl(DBD::Pg) BR and probably dep too

Suggestions:

- honor %{?_smp_mflags}


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.