[Bug 188105] Review Request: torque

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: torque


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=188105





------- Additional Comments From garrick at usc.edu  2006-04-10 19:23 EST -------
(In reply to comment #7)
>   W: torque incoherent-version-in-changelog 2.1.0p0-0.3.200604071240
>      2.1.0p0-0.4.200604071240
> 
> the naming does not exactly follow the pattern in 
>   http://fedoraproject.org/wiki/Packaging/NamingGuidelines 
> but it is pretty close -- could you please use the "YYYYMMDDcvs" 
> pattern per the guidelines?

I'll add a "cvs" on the end.


>   W: torque-client unstripped-binary-or-object /usr/sbin/pbs_iff
>   E: torque-client setuid-binary /usr/sbin/pbs_iff root 04755
>   E: torque-client non-standard-executable-perm /usr/sbin/pbs_iff 04755
> 
> These are worrisome.  The unstripped binary can probably be fixed
> in the rpm build somehow.  And does the /usr/sbin/pbs_iff really 
> need to be suid?

Yes, pbs_iff needs to get a priv port as part of TORQUE's internal authn system.
 
>   E: torque-mom non-standard-dir-perm /var/torque/checkpoint 0700
>   E: torque-mom non-standard-dir-perm /var/torque/undelivered 01777
>   E: torque-mom non-standard-dir-perm /var/torque/mom_priv/jobs 0751
>   W: torque-mom non-standard-dir-in-var torque
>   W: torque-mom incoherent-init-script-name pbs_mom
>   E: torque-scheduler non-standard-dir-perm /var/torque/sched_priv 0750
>   W: torque-scheduler non-standard-dir-in-var torque
>   W: torque-scheduler incoherent-init-script-name pbs_sched
>   E: torque-server non-standard-dir-perm /var/torque/server_priv/acl_groups 0750
>   E: torque-server non-standard-dir-perm /var/torque/server_priv/queues 0750
>   E: torque-server non-standard-dir-perm /var/torque/server_priv 0750
>   E: torque-server non-standard-dir-perm /var/torque/server_priv/acl_hosts 0750
>   E: torque-server non-standard-dir-perm /var/torque/server_priv/acl_users 0750
>   E: torque-server non-standard-dir-perm /var/torque/server_priv/acl_svr 0750
>   E: torque-server non-standard-dir-perm /var/torque/server_priv/jobs 0750
>   W: torque-server non-standard-dir-in-var torque
>   W: torque-server incoherent-init-script-name pbs_server
> 
> The above can probably (?) be ignored.
> 

Yup, that's all correct.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.