[Bug 187304] Review Request: echoping latency meassure tool

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: echoping latency meassure tool


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=187304





------- Additional Comments From andreas at bawue.net  2006-04-12 23:01 EST -------
(In reply to comment #1)

Thanks for the review.

> So IMO this package should be released unter GPL since the GPL is more
> restrictive than the "BSDish" license of openssl, right?
The License-Tag in the .spec has always been GPL. The package is released under
the GPL and not under the BSD license. The notice about the BSD license is in
there as openssl is under the BSD license and the GPL software should receive a
special permission to link against differently-free soft.
Thus it's a non-issue.
 
> Needswork:
> - MUST: increase the release to -1, -0* is not a valid release (at least for a
> stable version)
fixed.

> - MUST: directory ownership or permissions issues as %defattr is wrong: Change
> "%defattr(-, root, root)" to "%defattr(-, root, root,-)"
fixed.
 
> - SHOULD: make macro usage more consistent: Please use $RPM_BUILD_ROOT instead
> of %{buildroot}
According to the guidelines, either one is okay.

> - SHOULD: please change "%{__make} %{?_smp_mflags}" to "make %{?_smp_mflags}"
> (just for simplicity, there's no need to need to cover make with a macro)
> - SHOULD: remove the empty NEWS from %doc.
> - SHOULD: I suggest you add DETAILS to the %doc section as well.
> - SHOULD: Please change "Initial RPM release" to something like "Initial Fedora
> Extras release". There are already some echoping rpms in 3rd party repos.
All fixed.

That should be all. If you could please do a final review. thx.


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.