[Bug 173459] Review Request: initng

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: initng


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=173459





------- Additional Comments From enrico.scholz at informatik.tu-chemnitz.de  2006-04-14 06:16 EST -------
I would use virtual packages to express the initng -> ifiles dependency;
e.g.

 ,-- initng.spec:
| Requires:   initng(ifiles)


 ,-- initng-ifiles:
| Provides:   initng(ifiles)

(the parenthesis are just syntactic sugar; don't use it when you dislike it)


Currently, you require the specific 'initng-ifiles' package which
bring in my concerns from comment #215.



Else:
* I would not use versioned BuildRequires; you want a certain upstream
  version (API) of the selinux libraries but support for expression
  such a wish was removed some time ago from 'rpm'. Currently you can
  express a wish for a certain package version only; every supported
  Fedora Core version has these package versions so it is superflously.

  Since Fedora Extras tends to minimize the explicitly stated
  BuildRequires:, the version should be removed.

  Ditto for 'filesystem >= 2.2.4-1'; Fedora Core >= 4 has this package.


* initng-devel should require full-versioned main-package (inclusive
  %release)

* Missing SMP flags. If it doesn't build with it, please add a comment
  (wiki: PackagingGuidelines#parallelmake) (cited from comment #9)

* the first part of %post should be moved into a

  | %triggerin -- mkinitrd

  section. You should add

  | Requires(triggerin): grep coreutils

  too.

  The 'grep ... >/dev/null' can be expressed as

  | grep -q ...


* are the '*.la' files really needed?

* the

  | %install
  | ...
  | mv %{buildroot}%{_datadir}/doc/%{name}/* %{buildroot}/%{_docdir}/%{name}-%{version}/
  | cp -a COPYING AUTHORS ... %{buildroot}/%{_docdir}/%{name}-%{version}/
  | ...
  | %files
  | %doc %{_docdir}/%{name}-%{version}

  can be written as

  | %install
  | ...
  | mkdir _doc
  | mv %{buildroot}%{_datadir}/doc/%{name}/* _doc/
  | 
  | %files
  | %doc COPYING AUTHORS ...
  | %doc _doc/*

* the URL must be updated

* the provided .bz2 should be used instead of the .gz

* the '/%{_includedir}' in

  | %files devel
  | /%{_includedir}/initng

  can be written without leading '/' as

  | %{_includedir}/initng

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.