On Sat, 2006-04-29 at 21:08 -0500, Jason L Tibbitts III wrote: > I'm reviewing a package (rapidsvn, > https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=190139) that > makes rpmlint complain: > > E: rapidsvn binary-or-shlib-defines-rpath /usr/bin/rapidsvn ['/usr/lib64'] > > I have tried absolutely everything I can think of to get rid of this. > Either it doesn't work or it breaks the build. > > Now rpmlint says this is an error, but > http://fedoraproject.org/wiki/Extras/Schedule/RpathCheckBuildsys > says this is a minor issue. So I'm not sure what to do; if the > package can't be approved as is then could someone who actually > understands autoconf and libtool (i.e. not me) take a look? > Here's the link line where the rpath is inserted:: g++ -O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector --param=ssp-buffer-size=4 -m64 -mtune=generic -Wall -g -fexceptions -I/usr/lib64/wx/include/gtk2-unicode-release-2.6 -I/usr/include/wx-2.6 -DGTK_NO_CHECK_CASTS -D__WXGTK__ -D_FILE_OFFSET_BITS=64 -D_LARGE_FILES -DNO_GCC_PRAGMA -o .libs/svncpptest svncpptest-main.o svncpptest-test_url.o svncpptest-test_path.o -L/pkgs/cvs/rapidsvn-0.9.1-2/rapidsvn-0.9.1/src/svncpp -L/usr/lib64 -lcppunit /pkgs/cvs/rapidsvn-0.9.1-2/rapidsvn-0.9.1/src/svncpp/.libs/libsvncpp.so /usr/lib64/libsvn_client-1.so /usr/lib64/libsvn_wc-1.so /usr/lib64/libsvn_ra-1.so /usr/lib64/libsvn_delta-1.so /usr/lib64/libsvn_subr-1.so /usr/lib64/libneon.so /usr/lib64/libapr-1.so -lpthread -ldl /usr/lib64/libaprutil-1.so -lldap -llber /usr/lib64/libdb-4.3.so /usr/lib64/libexpat.so -Wl,--rpath -Wl,/usr/lib64 It's being added into the link line by libtool. Here's how to get rid of it:: make LIBTOOL=/usr/bin/libtool I've updated the wiki page to reflect that this may sometimes be the best way to pass the LIBTOOL line into the build. (And yes, it is best to avoid RPATHs whenever possible.) -Toshio
Attachment:
signature.asc
Description: This is a digitally signed message part