[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

[Bug 174494] Review Request: libopensync-plugin-irmc



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: libopensync-plugin-irmc


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=174494


jpmahowald gmail com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
OtherBugsDependingO|163778                      |163779
              nThis|                            |




------- Additional Comments From jpmahowald gmail com  2006-02-04 01:38 EST -------
- rpmlint checks return:

rpmlint of libopensync-plugin-irmc-0.18-2.i386.rpm:E: libopensync-plugin-irmc
zero-length /usr/share/doc/libopensync-plugin-irmc-0.18/ChangeLog
E: libopensync-plugin-irmc zero-length
/usr/share/doc/libopensync-plugin-irmc-0.18/AUTHORS
E: libopensync-plugin-irmc zero-length
/usr/share/doc/libopensync-plugin-irmc-0.18/README
E: libopensync-plugin-irmc zero-length
/usr/share/doc/libopensync-plugin-irmc-0.18/NEWS

Empty doc files go.

Good:
- package meets naming guidelines
- package meets packaging guidelines
- license (GPL) OK, text in %doc, matches source
- spec file legible, in am. english
- source matches upstream
- package compiles on FC4 i386
- no missing BR
- no unnecessary BR
- no locales
- not relocatable
- owns all directories that it creates
- no duplicate files
- permissions ok
- %clean ok
- macro use consistent
- code, not content
- no need for -docs
- nothing in %doc affects runtime
- no need for .desktop file

Ax the empty files and this is APPROVED.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]