[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

[Bug 180034] Review Request: perl-Font-TTF (part of the dejavu-fonts toolchain)

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-Font-TTF (part of the dejavu-fonts toolchain)


tibbs math uh edu changed:

           What    |Removed                     |Added
OtherBugsDependingO|163776                      |163778
              nThis|                            |

------- Additional Comments From tibbs math uh edu  2006-02-04 20:27 EST -------
Generally you should supply a src.rpm; it makes the review process a bit easier
and some of the review items require having it.

My rpmlint complains:
W: perl-Font-TTF wrong-file-end-of-line-encoding

and indeed README.TXT has CRLF endings.  However, there are several packages
which include documentation files with DOS-style line endings so I don't believe
this is a blocker.  Fix it up if you like.

Other issues:
I can't review spec file naming.
I can't review the source used to build the SRPM as none was provided.
BuildRequires: perl is not permitted.
The license does not seem to be GPL.  I see only:

The Perl TTF module is licensed under the Perl Artistic License.

I don't understand this comment in the %files section:

# For arch-specific packages: vendorarch

I can't install the resulting RPM:

error: Failed dependencies:
        perl(Win32) is needed by perl-Font-TTF-0.37-1.noarch
        perl(Win32::Registry) is needed by perl-Font-TTF-0.37-1.noarch

I believe this is the result of lib/Font/TTF/Win32.pm.  I'm not sure what would
be best to do here.  You can fix it with a quick

rm %{buildroot}/%{perl_vendorlib}/Font/TTF/Win32.pm

in the %install section but I'm not completely sure if that's acceptable. 
Another solution would be to postprocess the output of the dependency generator,
but that's rather unpalatable as well (and more complicated than just deleting
the file).

Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.

[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]