[Bug 179818] Review Request: xpilot-ng - A mutiplayer space arcade game

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: xpilot-ng - A mutiplayer space arcade game


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=179818


j.w.r.degoede at hhs.nl changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|bugzilla-sink at leemhuis.info |j.w.r.degoede at hhs.nl
OtherBugsDependingO|163776                      |163778
              nThis|                            |




------- Additional Comments From j.w.r.degoede at hhs.nl  2006-02-05 05:21 EST -------
MUST items:
* rpmlint output is clean
* package and spec name matches upstream
* GPL license valid, matches upstream, license file included
* Meets packaging guidelines
* Spec file is legible and in Am. English.
* Source matches upstream (md5sum ok)
* Builds cleanly on FC5 x86_64
* Valid BR; none are redundant
* No lang files; no shlibs.
* Package not relocatable
* 0wns all directories that it creates
* File permissions ok
* %clean looks good
* code and content, both under GPL
* minimal doc files, do not affect runtime
* no -devel package necessary
* desktop file installed correctly

SHOULD items:
* Runs although I have yet to figure out the keys to use.

MUST FIX:
*use %{version} in Source0
*don't cp the doc-files to .server versions use just them 2 times in the %doc
 parts of the %files sections
*icons should be installed in /usr/share/icons/hicolor/48x48/apps/
 (freedekstop.org standard)
*and then should run gtk-update-icon-cache in %post(un), use the
 scriptlets found on: http://www.fedoraproject.org/wiki/ScriptletSnippets
 for this.


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.