[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

[Bug 180034] Review Request: perl-Font-TTF (part of the dejavu-fonts toolchain)



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-Font-TTF (part of the dejavu-fonts toolchain)


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=180034





------- Additional Comments From tibbs math uh edu  2006-02-05 10:26 EST -------
I agree about the BuildRequires: perl thing, and indeed in another review I said
it was not a blocker (which was my mistake) but then I noticed the MUST.  I'm
not sure what to do here; I think the MUST is unnecessary and conflicts with
language in the the packaging guidelines:

"There is no need to include the following packages or their dependencies as
BuildRequires because they would occur too often."

which doesn't sound very MUST like.

We can't just ignore the guidelines, so I suggest removing the BuildRequires:
while this gets worked out on the mailing list.

Also, could you comment the %exclude you added, so it's obvious why this is
required.

I'll finish off the review in a few minutes.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]