[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

[Bug 179802] Review Request: seamonkey



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: seamonkey


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=179802





------- Additional Comments From caillon redhat com  2006-02-05 13:33 EST -------
Review comments:
- Is this really distributed under NPL/MPL?  I think it should be MPL/GPL/LGPL
- Lose the Prefix: tag
- Don't BuildRequire autoconf213; if you make changes to configure, include that
part in the patch
- Remove the ExclusiveArch.  You are including all of our current platforms, and
it probably builds on others that we don't.
- You probably ought to have the FindExternalProvides stuff that the Firefox and
Thunderbird package does.  Since the libraries provided aren't versioned, this
can cause problems when two packages provide the same libraries (mozilla also
provides these for now, and when xulrunner eventually takes over, it will do so).
- I think you can safely remove the conditional for desktop_file, unless you
really want to push this to really old releases (I think FC1 needed it, newer
don't).
- Without a GRE, the -devel package should arguably not be built since that is a
key part of the -devel platform.
- regxpcom is no longer required.  This (and the entire block surrounding it)
should go away.
- Your comment about cp -L doesn't seem needed.
- Since this is for Fedora Extras, you probably shouldn't name the default
pref/bookmarks files with redhat :-)
- seamonkey-rebuild-databases should not be needed
- I don't think selinux/chcon stuff should be in this specfile.  Is there a bug
you are trying to work around?
- The following are installed with +x and shouldn't be.  Using a %defattr in
%files with the appropriate modes will fix this.
++ seamonkey ++
/usr/lib/seamonkey-1.0/components/nsXmlRpcClient.js
/usr/lib/seamonkey-1.0/components/nsComposerCmdLineHandler.js
/usr/lib/seamonkey-1.0/components/nsSidebar.js
/usr/lib/seamonkey-1.0/components/nsProgressDialog.js
/usr/lib/seamonkey-1.0/components/nsCloseAllWindows.js
/usr/lib/seamonkey-1.0/components/nsHelperAppDlg.js
/usr/lib/seamonkey-1.0/components/nsFilePicker.js
/usr/lib/seamonkey-1.0/components/nsDictionary.js
/usr/lib/seamonkey-1.0/components/nsUpdateNotifier.js
/usr/lib/seamonkey-1.0/components/nsDownloadProgressListener.js
/usr/lib/seamonkey-1.0/components/jsconsole-clhandler.js
/usr/lib/seamonkey-1.0/components/nsProxyAutoConfig.js
/usr/lib/seamonkey-1.0/components/nsResetPref.js
/usr/lib/seamonkey-1.0/components/nsInterfaceInfoToIDL.js
++ seamonkey-chat ++
/usr/lib/seamonkey-1.0/components/chatzilla-service.js
++ seamonkey-dom-inspector ++
/usr/lib/seamonkey-1.0/components/inspector-cmdline.js
++ seamonkey-js-debugger ++
/usr/lib/seamonkey-1.0/components/venkman-service.js
++ seamonkey-mail ++
/usr/lib/seamonkey-1.0/components/offlineStartup.js
/usr/lib/seamonkey-1.0/components/nsLDAPPrefsService.js
/usr/lib/seamonkey-1.0/components/nsAbLDAPAttributeMap.js
/usr/lib/seamonkey-1.0/components/smime-service.js
/usr/lib/seamonkey-1.0/components/mdn-service.js
++++


Optional:
- Use a .mozconfig file (see what I do in the firefox package).  This will make
it easier to do development with the same flags with a different tree (just copy
the mozconfig over)


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]