[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

[Bug 175281] Review Request: perl-Tie-EncryptedHash



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-Tie-EncryptedHash


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=175281





------- Additional Comments From tibbs math uh edu  2006-02-07 16:41 EST -------
perl-Crypt-DES isn't built on the FC-4 branch yet so I build it from CVS.

There's not really much to this package.  The shebang line at the top of the
module is odd; thanks for removing it.

Good stuff:
pmlint is completely silent.
Package meets naming and packaging guidelines.
Specfile is properly named, legible, and uses macros consistently.
BuildRequires: is proper.
License is acceptable and matches License: tag.
Source file md5sum matches upstream.
Package builds and installs on FC4 x86 and FC3 x86_64.

Odd stuff:
The tests spew a few (nine) warnings.  They don't seem to affect the outcome.

t/operations test takes fifteen seconds on FC3 x86_64 but seems to be
instantaneous on i386.  Everything does build and pass on x86_64 so I'm not sure
what the issue is.

I see no reason why either of these should be blockers.

Approved.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]