[Bug 169717] Review Request: Internode DSL usage applet

bugzilla at redhat.com bugzilla at redhat.com
Thu Feb 9 19:07:12 UTC 2006


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: Internode DSL usage applet


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=169717





------- Additional Comments From wart at kobold.org  2006-02-09 14:06 EST -------
Just a couple of initial comments:

* I believe the Requires: python-abi is no longer needed for FC4+5.
* Use %{SOURCE1} in %prep instead of %{_sourcedir}.  It's a little easier to read.
* There is a debug 'echo' line in %install

I've never been clear on the recommendations for .pyc files.  Should these be
shipped or %ghosted?

I will try to do a more formal review later today...

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.




More information about the fedora-extras-list mailing list