[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

[Bug 176528] Review Request: MochiKit: A lightweight JavaScript library



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: MochiKit: A lightweight JavaScript library


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=176528





------- Additional Comments From tibbs math uh edu  2006-02-10 18:32 EST -------
Sorry for taking so long....

After seeing the Cacti package go in, I'll drop any objection I had to storing
the files in /usr/share.  And rpmlint only complains about the license, which is
not an issue since the license is valid.

So:
No rpmlint blockers, just the end-of-line warning.
Package meets naming and packaging guidelines.
License is acceptable and matches License: tag.
Specfile is properly named, legible, well-written, well-commented and uses
macros consistently.
Source file matches upstream.
Package builds and installs on FC3 and FC4.

I'd just like clarification on one thing.  It's not common practise to install
package tests under %doc (or even to install them at all).  I understand that
it's not really possible to execute those tests in any meaningful way at build
time, but I wonder what your reasoning is behind including them in the final
package.  Examples are already included, so the tests don't really add much in
the way of documentation.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]