[Bug 181450] Review Request: clamav-exim - Clam AV support files for Exim

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: clamav-exim - Clam AV support files for Exim


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=181450


orion at cora.nwra.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|bugzilla-sink at leemhuis.info |orion at cora.nwra.com
OtherBugsDependingO|163776                      |163778
              nThis|                            |




------- Additional Comments From orion at cora.nwra.com  2006-02-15 14:40 EST -------

- rpmlint checks return:

W: clamav-exim no-url-tag
W: clamav-exim no-documentation
E: clamav-exim incoherent-logrotate-file /etc/logrotate.d/clamd.exim
E: clamav-exim non-standard-uid /var/run/clamd.exim clamexim
E: clamav-exim non-standard-gid /var/run/clamd.exim exim
E: clamav-exim non-standard-dir-perm /var/run/clamd.exim 0750
E: clamav-exim non-standard-gid /var/log/clamd.exim exim
E: clamav-exim non-root-group-log-file /var/log/clamd.exim exim
W: clamav-exim dangerous-command-in-%post chmod
^ If you really need a log file, perhaps create in %install?

E: clamav-exim init-script-name-with-dot /etc/rc.d/init.d/clamd.exim
E: clamav-exim no-status-entry /etc/rc.d/init.d/clamd.exim
W: clamav-exim no-reload-entry /etc/rc.d/init.d/clamd.exim
E: clamav-exim subsys-not-used /etc/rc.d/init.d/clamd.exim
W: clamav-exim incoherent-init-script-name clamd.exim


- license (GPL) OK, need text in %doc.

?
- No upstream, is this okay?
- macro use not consistent between %var and %{var}

Good:

- package meets naming guidelines
- package meets packaging guidelines
- spec file legible, in am. english
- package compiles on devel (x86)
- no missing BR
- no unnecessary BR
- no locales
- not relocatable
- owns all directories that it creates
- no duplicate files
- %clean ok
- code, not content
- no need for -docs
- nothing in %doc affects runtime
- no need for .desktop file


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.