[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

[Bug 180897] Review Request: heartbeat



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: heartbeat


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=180897


orion cora nwra com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|bugzilla-sink leemhuis info |orion cora nwra com
OtherBugsDependingO|163776                      |163778
              nThis|                            |




------- Additional Comments From orion cora nwra com  2006-02-15 15:01 EST -------
Not full review yet, but close.

- rpmlint checks return:

W: heartbeat non-standard-group Networking/Daemons
E: heartbeat hardcoded-library-path in
$RPM_BUILD_ROOT/usr/lib/heartbeat/crmtest/helper.sh
E: heartbeat hardcoded-library-path in /usr/lib/libhbmgmt.*
E: heartbeat hardcoded-library-path in /usr/lib/libhbmgmtclient.*
E: heartbeat hardcoded-library-path in /usr/lib/libhbmgmtcommon.*
E: heartbeat hardcoded-library-path in /usr/lib/libhbmgmttls.*
  
Needs work:
* Spec file: some paths are not replaced with RPM macros
  (wiki: QAChecklist item 7)
* The BuildRoot must be cleaned at the beginning of %install

- Why split into -stonith and -pils packages but have the base package require them?

Good:
- package meets naming guidelines
- package meets packaging guidelines
- license (GPL/LGPL) OK, text in %doc, matches source
- spec file legible, in am. english
- source matches upstream
- package compiles on devel (x86)
- no missing BR
- no unnecessary BR
- no locales
- not relocatable
- owns all directories that it creates
- no duplicate files
- permissions ok
- %clean ok
- macro use consistent
- code, not content
- no need for -docs
- nothing in %doc affects runtime
- no need for .desktop file

Nitpicks:

- use %setup -q



-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]