[Bug 180897] Review Request: heartbeat

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: heartbeat


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=180897





------- Additional Comments From orion at cora.nwra.com  2006-02-16 16:40 EST -------
Okay, moving on.. :-)

%package ldirectord
Summary:        Monitor daemon for maintaining high availability resources
Group:          System Environment/Daemons
Requires:       perl-libwww-perl
Requires:       perl-Crypt-SSLeay
Requires:       ipvsadm
Requires:       perl-HTML-Parser
Requires:       perl-LDAP
#Requires:       perl-Mail-IMAPClient
Requires:       perl-Net-DNS

None of the perl stuff is needed as rpmbuild automatically picks up perl module
dependencies.


- Trying to install heartbeat gave me:

useradd: cannot create directory /home/hacluster
error: %pre(heartbeat-2.0.3-3.fc5.i386) scriptlet failed, exit status 12
error:   install: %pre scriptlet failed (2), skipping heartbeat-2.0.3-3.fc5

The user creation section has to be changed.  Fedora Extras packages can't
create system users.  You might check out
http://fedoraproject.org/wiki/Packaging/UserCreation?action=show&redirect=PackageUserCreation

Also, I get:

useradd: cannot create directory /var/lib/heartbeat/cores/hacluster

with the current useradd command, so I think you need to create the directory as
part of the package (perhaps useradd doesn't use mkdir -p).

- rpmlint:

# rpmlint heartbeat-pils
W: heartbeat-pils devel-file-in-non-devel-package /usr/lib/libpils.so
^ this should be in heartbeat-devel (or heartbeat-pils-devel)

E: heartbeat-pils library-without-ldconfig-postin /usr/lib/libpils.so.1.0.0
E: heartbeat-pils library-without-ldconfig-postun /usr/lib/libpils.so.1.0.0
^ needs:
%post pils -p /sbin/ldconfig
%postun pils -p /sbin/ldconfig

# rpmlint heartbeat-stonith
E: heartbeat-stonith library-without-ldconfig-postin /usr/lib/libstonith.so.1.0.0
E: heartbeat-stonith library-without-ldconfig-postun /usr/lib/libstonith.so.1.0.0
^ needs:
%post stonith -p /sbin/ldconfig
%postun stonith -p /sbin/ldconfig

W: heartbeat-stonith devel-file-in-non-devel-package /usr/lib/libstonith.so
^ should be in heartbeat-devel (or heartbeat-stonith-devel)


# rpmlint -i heartbeat-ldirectord
W: heartbeat-ldirectord devel-file-in-non-devel-package
/usr/sbin/supervise-ldirectord-config
A development file (usually source code) is located in a non-devel
package. If you want to include source code in your package, be sure to
create a development package.

E: heartbeat-ldirectord incoherent-logrotate-file /etc/logrotate.d/ldirectord
Your logrotate file should be named /etc/logrotate.d/<package name>.

W: heartbeat-ldirectord non-conffile-in-etc /etc/logrotate.d/ldirectord
A non-executable file in your package is being installed in /etc, but is not
a configuration file. All non-executable files in /etc should be configuration
files. Mark the file as %config in the spec file.

E: heartbeat-ldirectord init-script-without-chkconfig-postin /etc/init.d/ldirectord
The package contains an init script but doesn't contain a %post with
a call to chkconfig.

E: heartbeat-ldirectord init-script-without-chkconfig-preun /etc/init.d/ldirectord
The package contains an init script but doesn't contain a %preun with
a call to chkconfig.

W: heartbeat-ldirectord service-default-enabled /etc/init.d/ldirectord
The service is enabled by default after "chkconfig --add"; for security
reasons, most services should not be. Use "-" as the default runlevel in the
init script's chkconfig line to fix this if appropriate for this service.

E: heartbeat-ldirectord subsys-not-used /etc/init.d/ldirectord
While your daemon is running, you have to put a lock file in
/var/lock/subsys/. To see an example, look at this directory on your
machine and examine the corresponding init scripts.

W: heartbeat-ldirectord incoherent-init-script-name ldirectord
The init script name should be the same as the package name in lower case.




-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.