[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

[Bug 181803] Review Request: scrub



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: scrub


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=181803





------- Additional Comments From bdpepple ameritech net  2006-02-17 11:17 EST -------
I don't have permission to sponser you, but here's an initial package review.

MD5Sum:
faf66a307afbd06d57f617fa3176870f  scrub-1.7.tar.bz2

Good:
* Source URL is canonical
* Upstream source tarball verified
* Package name conforms to the Fedora Naming Guidelines
* Buildroot has all required elements
* All paths begin with macros
* All necessary BuildRequires listed.
* Files have appropriate permissions and owners
* Package builds fine in Mock for FC5.
* Rpmlint does not find problems

Bad:
* Missing (rm -rf $RPM_BUILD_ROOT) at beginning of %install section.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]