[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

[Bug 180068] Review Request: geoip - Library for mapping IP/hostname to a country/city/organization



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: geoip - Library for mapping IP/hostname to a country/city/organization


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=180068





------- Additional Comments From mfleming+rpm enlartenment com  2006-02-17 21:11 EST -------

Another round o' SRPMS :-)

http://www.enlartenment.com/extras/GeoIP.spec
http://www.enlartenment.com/extras/GeoIP-1.3.14-3.src.rpm

(In reply to comment #3)
> (In reply to comment #2)
> > (some warnings re:
> > the .so symlinks, but that's about all.)
> 
> This is a blocker, please fix (lib*.so must go to *-devel, lib*.so.* to non-devel)

Done.

> 
> 
> Also arguable:
> Obsoletes: geoip
> Provides: geoip
> 
> This should probably be:
> Obsoletes: geoip < %{version}-%{release}
> Provides: geoip = %{version}-%{release}

Done, with a similar pairing for -devel to ensure it's handled reasonably cleanly.

> Also missing in the *-devel package:
> Provides: geoip-devel = %{version}-%{release}
> 
> Alternatively, you could consider to drop supporting "geoip".

Doable, but given that both I and Rudolf Kastl have shipped packages as "geoip"
in the past I felt it best to go with the above suggestions and give the user a
clean upgrade path (working on the principle of least surprise)

Michael.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]