[Bug 180345] Review Request: ser - Sip Express Router

Sat Feb 18 04:31:09 UTC 2006

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: ser - Sip Express Router

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=180345

------- Additional Comments From jeff at ollie.clive.ia.us  2006-02-17 23:31 EST -------
Here's the full review:

- MUST: rpmlint must be run on every package. The output should
  be posted in the review.

Not OK:

[jcollie at lt16585 result]$ rpmlint ser-*.i386.rpm | grep -v debuginfo
W: ser-postgresql doc-file-dependency
/usr/share/doc/ser-postgresql-0.9.6/copy_to_psql /usr/bin/perl

Remove execute permission from this script and dependency shouldn't be picked up.

- MUST: The package must be named according to the Package
  Naming Guidelines.

OK

- MUST: The spec file name must match the base package %{name},
  in the format %{name}.spec

OK

- MUST: The package must meet the Packaging Guidelines.

OK, with the following notes:

Could the serweb html files be moved to /var/www/html/serweb?  This
could potentially be a problem with SELinux, as well as conforming
more to existing practice.

I see that serweb includes an (old) copy of the Smarty templating
system. Smarty is already in FE.  Is it possible to remove the copy
from serweb and use the newer version from FE?  It looks like you
could delete everything but smarty_serweb.php.  After patching up that
file (and manybe some others) you should be able to use the FE
version.

- MUST: The package must be licensed with an open-source
  compatible license and meet other legal requirements as
  defined in the legal section of Packaging Guidelines.

OK (GPL)

- MUST: The License field in the package spec file must match
  the actual license.

OK

- MUST: If (and only if) the source package includes the text of
  the license(s) in its own file, then that file, containing the
  text of the license(s) for the package must be included in
  %doc.

OK

- MUST: The spec file must be written in American English.

OK

- MUST: The spec file for the package MUST be legible. If the
  reviewer is unable to read the spec file, it will be
  impossible to perform a review. Fedora Extras is not the place
  for entries into the Obfuscated Code Contest ([WWW]
  http://www.ioccc.org/).

OK

- MUST: The sources used to build the package must match the
  upstream source, as provided in the spec URL. Reviewers should
  use md5sum for this task.

OK

31031225d483c0d5ac43e8eb5d0428e0  originals/ser-0.9.6_src.tar.gz
fa0647598c9370c91650386befd63fba  originals/serweb-0.9.4.tar.gz
31031225d483c0d5ac43e8eb5d0428e0  sources/ser-0.9.6_src.tar.gz
fa0647598c9370c91650386befd63fba  sources/serweb-0.9.4.tar.gz

- MUST: The package must successfully compile and build into
  binary rpms on at least one supported architecture.

OK (builds on i386/devel & i386/FC4)

- MUST: If the package does not successfully compile, build or
  work on an architecture, then those architectures should be
  listed in the spec in ExcludeArch. Each architecture listed in
  ExcludeArch needs to have a bug filed in bugzilla, describing
  the reason that the package does not compile/build/work on
  that architecture. The bug number should then be placed in a
  comment, next to the corresponding ExcludeArch line. New
  packages will not have bugzilla entries during the review
  process, so they should put this description in the comment
  until the package is approved, then file the bugzilla entry,
  and replace the long explanation with the bug number. The bug
  should be marked as blocking one (or more) of the following
  bugs to simplify tracking such issues: [WWW]
  FE-ExcludeArch-x86, [WWW] FE-ExcludeArch-x64, [WWW]
  FE-ExcludeArch-ppc

OK

- MUST: A package must not contain any BuildRequires that are
  listed in the exceptions section of Packaging Guidelines.

OK

- MUST: All other Build dependencies must be listed in
  BuildRequires.

OK

- MUST: The spec file MUST handle locales properly. This is done
  by using the %find_lang macro. Using %{_datadir}/locale/* is
  strictly forbidden.

OK (no localized files)

- MUST: If the package contains shared library files located in
  the dynamic linker's default paths, that package must call
  ldconfig in %post and %postun. If the package has multiple
  subpackages with libraries, each subpackage should also have a
  %post/%postun section that calls /sbin/ldconfig. An example of
  the correct syntax for this is:

  %post -p /sbin/ldconfig
  %postun -p /sbin/ldconfig

OK

- MUST: If the package is designed to be relocatable, the
  packager must state this fact in the request for review, along
  with the rationalization for relocation of that specific
  package. Without this, use of Prefix: /usr is considered a
  blocker.

OK (not relocatable)

- MUST: A package must own all directories that it creates. If
  it does not create a directory that it uses, then it should
  require a package which does create that directory. The
  exception to this are directories listed explicitly in the
  Filesystem Hierarchy Standard ([WWW]
  http://www.pathname.com/fhs/pub/fhs-2.3.html), as it is safe
  to assume that those directories exist.

Not OK (/etc/ser not owned by main package.)

- MUST: A package must not contain any duplicate files in the
  %files listing.

Not OK (/etc/ser/serweb is duplicated between main package and serweb
subpackage.)

- MUST: Permissions on files must be set properly. Executables
  should be set with executable permissions, for example. Every
  %files section must include a %defattr(...) line.

OK

- MUST: Each package must have a %clean section, which contains
  rm -rf %{buildroot} (or $RPM_BUILD_ROOT).

OK

- MUST: Each package must consistently use macros, as described
  in the macros section of Packaging Guidelines.

Not OK (%clean section uses $RPM_BUILD_ROOT while %{buildroot} is used elsewhere.)

- MUST: The package must contain code, or permissable
  content. This is described in detail in the code vs. content
  section of Packaging Guidelines.

OK

- MUST: Large documentation files should go in a -docs
  subpackage. (The definition of large is left up to the
  packager's best judgement, but is not restricted to
  size. Large can refer to either size or quantity)

OK

- MUST: If a package includes something as %doc, it must not
  affect the runtime of the application. To summarize: If it is
  in %doc, the program must run properly if it is not present.

OK

- MUST: Header files or static libraries must be in a -devel
  package.

OK

- MUST: Files used by pkgconfig (.pc files) must be in a -devel
  package.

OK

- MUST: If a package contains library files with a suffix
  (e.g. libfoo.so.1.1), then library files that end in .so
  (without suffix) must go in a -devel package.

OK

- MUST: In the vast majority of cases, devel packages must
  require the base package using a fully versioned dependency.

OK

- MUST: Packages must NOT contain any .la libtool archives,
  these should be removed in the spec.

OK

- MUST: Packages containing GUI applications must include a
  %{name}.desktop file, and that file must be properly installed
  with desktop-file-install in the %install section. This is
  described in detail in the desktop files section of Packaging
  Guidelines. If you feel that your packaged GUI application
  does not need a .desktop file, you must put a comment in the
  spec file with your explanation.

OK

- MUST: Packages must not own files or directories already owned
  by other packages. The rule of thumb here is that the first
  package to be installed should own the files or directories
  that other packages may rely upon. This means, for example,
  that no package in Fedora Extras should ever share ownership
  with any of the files or directories owned by the filesystem
  or man package. If you feel that you have a good reason to own
  a file or directory that another package owns, then please
  present that at package review time.

OK

- SHOULD: If the source package does not include license text(s) as a
  separate file from upstream, the packager SHOULD query upstream to
  include it.

OK

- SHOULD: The description and summary sections in the package spec
  file should contain translations for supported Non-English
  languages, if available.

OK

- SHOULD: The reviewer should test that the package builds in mock.

OK (build in mock devel/i386)

- SHOULD: The package should compile and build into binary rpms on all
  supported architectures.

Tested i386/devel and i386/FC4.

- SHOULD: The reviewer should test that the package functions as
  described. A package should not segfault instead of running, for
  example.

OK (only main package tested)

- SHOULD: If scriptlets are used, those scriptlets must be sane. This
  is vague, and left up to the reviewers judgement to determine
  sanity.

OK

- SHOULD: Usually, subpackages other than devel should require the
  base package using a fully versioned dependency.

OK

Needs a bit more work, and then I'll approve it...

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.