[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

[Bug 180897] Review Request: heartbeat



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: heartbeat


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=180897





------- Additional Comments From fedora soeterbroek com  2006-02-18 11:25 EST -------
(In reply to comment #22)

Some questions regarding last comment #22: 
> None of the perl stuff is needed as rpmbuild automatically picks up perl module
> dependencies.
> 
Ok, fair enough. I did not know rpmbuild did this.
> 
> - Trying to install heartbeat gave me:
> 
> useradd: cannot create directory /home/hacluster
> error: %pre(heartbeat-2.0.3-3.fc5.i386) scriptlet failed, exit status 12
> error:   install: %pre scriptlet failed (2), skipping heartbeat-2.0.3-3.fc5
> 
> The user creation section has to be changed.  Fedora Extras packages can't
> create system users.  You might check out
>
http://fedoraproject.org/wiki/Packaging/UserCreation?action=show&redirect=PackageUserCreation
> 
I am not sure I understand what you mean by this. I think you want me to change
this line:
  USEROPT="-g haclient -u 17 -d /var/lib/heartbeat/cores/hacluster"
to:
  USEROPT="-g haclient -u $[ $(cat /etc/fedora/usermgmt/baseuid) + 17 ] -d
/var/lib/heartbeat/cores/hacluster"
Correct?
 
> - rpmlint:
> 
> # rpmlint heartbeat-pils
> W: heartbeat-pils devel-file-in-non-devel-package /usr/lib/libpils.so
> ^ this should be in heartbeat-devel (or heartbeat-pils-devel)
>
I am unsure what to do here:
* Do *.so files always go in a seperate -devel package or just in this case?
What to do with /usr/lib/pils/plugins/InterfaceMgr/generic.so file?
* You know that /usr/lib/libpils.so symlinks to
/usr/lib/libpils.so.1.0.0; should this also go in -devel package?

> E: heartbeat-pils library-without-ldconfig-postin /usr/lib/libpils.so.1.0.0
> E: heartbeat-pils library-without-ldconfig-postun /usr/lib/libpils.so.1.0.0
> ^ needs:
> %post pils -p /sbin/ldconfig
> %postun pils -p /sbin/ldconfig

If these files go to -devel package, then it should be
  %post devel -p /sbin/ldconfig
correct?





-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]