rpms/perl-Unicode-Map8/devel perl-Unicode-Map8.spec,1.7,1.8

[Ville Skyttä]

On Wed, 2006-02-22 at 03:40 -0500, Aurelien Bompard wrote:

> -%check || :
> -make test
> +%check
> +make test || :
[...]
>  %changelog
> +* Wed Feb 22 2006 Aurelien Bompard <gauret[AT]free.fr> 0.12-7
> +- disable unit tests (map8.t fails on x86_64)

Um, no.  You didn't disable the unit test, but just ignored its result.

And it's not "just" a unit test failure but a plain crash in t/map8.t's
test 2 ($no->recode8(...)), so this package is now pretty certainly
shipped broken for x86_64.  If it can't be fixed, please ExcludeArch
x86_64 instead (and also in all dependent packages), file the
appropriate Bugzilla ticket and refer to it in the specfile(s).


FYI, the compilation warnings building it on x86_64 are:

map8x.c: In function 'map8_recode8':
map8x.c:322: warning: pointer targets in passing argument 1 of 'strlen' differ in signedness
map8x.c:315: warning: unused variable 'uc'
[...]
Map8.xs: In function 'to8_cb':
Map8.xs:84: warning: pointer targets in return differ in signedness
Map8.xs: In function 'XS_Unicode__Map8__empty_block':
Map8.xs:201: warning: comparison is always false due to limited range of data type
Map8.c: In function 'XS_Unicode__Map8_to16':
Map8.c:490: warning: pointer targets in initialization differ in signedness
Map8.xs: In function 'XS_Unicode__Map8_recode8':
Map8.xs:359: warning: implicit declaration of function 'map8_recode8'
Map8.c: At top level:
/usr/lib64/perl5/5.8.8/x86_64-linux-thread-multi/CORE/patchlevel.h:122: warning: 'local_patches' defined but not used

"implicit declaration of function 'map8_recode8'" looks susceptible.