[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

[Bug 182122] Review Request: multitail



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: multitail


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=182122


jpo di uminho pt changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jpo di uminho pt




------- Additional Comments From jpo di uminho pt  2006-02-22 15:35 EST -------
Two more minor suggestions:

* We only need to override CFLAGS (no need to override the value of CC).
  The following line resolves the distro CFLAGS inheritance problem:

     CFLAGS="%{optflags}" make %{?_smp_mflags}

* We can also drop the %doc tag from the man page entry in the %files section.
  (rpm automatically tags manpages as doc files).

Everything else looks good with Jason's patch applied.

/jpo

PS - And the package can also be updated to version 3.8.7 ;)

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]