[Bug 180430] Review Request: Tong - a game of skill

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: Tong - a game of skill


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=180430





------- Additional Comments From tibbs at math.uh.edu  2006-02-23 00:11 EST -------
Well, I tried again and the checksums do match what you get.  I had tried
multiple times before.  (I was using spectool, which uses wget, so there
shouldn't be a browser caching issue.)

Yes, props for the improved hack.  Much better.

rpmlint now complains only about tong-data having no documentation; no problem
there.

The only remaining issue is %{optflags} (or $RPM_OPT_FLAGS), which isn't getting
passed.  The Makefile doesn't support CFLAGS, but you can set CC:

make CC="%{__cc} %{optflags}" GAME_DATA_DIR=%{_datadir}/tong %{?_smp_mflags}

This produces a build that contains proper debug info (so the debuginfo package
actually contains something) and uses recommended flags like FORTIFY_SOURCE. 
Unfortunately I can't test the package from home so I'll have to wait until
tomorrow.

Beyond that I don't see any remaining issues; I'll test and run some mock builds
tomorrow.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.