[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

[Bug 183028] Review Request: perl-Spiffy



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-Spiffy


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=183028





------- Additional Comments From tibbs math uh edu  2006-02-27 14:52 EST -------
Look, he's trying to come up with a solution that doesn't involve hacking 130
downstream packages.  If you don't want to be constructive then please just
don't post.

Steve, I'm working on filtering the requires and it's really simple; you just
need six lines in %prep.  Looking through what other packages in Core and Extras
do, I see that this is really very common:

cat << EOF > %{name}-req
#!/bin/sh
%{__perl_requires} $* | sed -e '/perl(mixin)/d'
EOF
%define __perl_requires %{_builddir}/%{name}-%{version}/%{name}-req
chmod +x %{__perl_requires}

(You can also reference an external script as %{SOURCE99} if you find emitting
it from the spec distasteful.)

Finally, I was hacking on the packages and noticed that Spiffy also provides
perl(DB), which I think is broken.  (It overrides the super() method in the DB
package, and so it has a "package DB" statement which RPM turns into Provides:
perl(DB).)  This has the capacity to break other things, so Spiffy is definitely
going to need a __perl_provides override as well:

cat <<XXX > %{name}-prov
#!/bin/sh
%{__perl_provides} $* | sed -e '/perl(DB)/d'
XXX
%define __perl_provides %{_builddir}/Spiffy-%{version}/%{name}-prov
chmod +x %{__perl_provides}

With this, things are working cleanly.

I know it's a pain to have to do this in all of the modules, but I think this is
going to be the only way to move forward.  I will try to get these overrides
into the Perl template and I suggest that they get into cpanspec as well.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]