[Bug 182737] Review Request: kdetoys
bugzilla at redhat.com
bugzilla at redhat.com
Sun Mar 5 23:19:09 UTC 2006
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: kdetoys
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=182737
------- Additional Comments From rdieter at math.unl.edu 2006-03-05 18:18 EST -------
> * BuildRequires: gettext is missing (required by the %find_lang macro)
Really? Didn't know that, thanks.
> * The package should contain the text of the license
Duh, can't believe I missed that.
> * The package contains libtool archive files (*.la)
These are for loadable modules, not shared libraries. Regardless, in this case,
they're needed.
> * Desktop files: some don't contain the "Application" category,
> and the "vendor" should be fedora. (wiki: PackagingGuidelines#desktop)
Category: OK. vendor, I recently raised that issue on the packagers mailing
list and the consensus was to only use fedora as vendor in the absense of an
existing/proper one (in this case, the proper vendor is kde).
> * maybe "%{!?debug_package:-strip}" can be dropped
Yeah, probably. That's just to help folks who don't have redhat-rpm-config
installed.
--
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.
More information about the fedora-extras-list
mailing list