[Bug 166960] Review Request: Fuse-emulator

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: Fuse-emulator


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=166960





------- Additional Comments From tcallawa at redhat.com  2006-03-07 11:09 EST -------
Good:

- rpmlint checks return nothing
- package meets naming guidelines
- package meets packaging guidelines
- license (GPL) OK, text in %doc, matches source
- spec file legible, in am. english
- package compiles on devel (x86)
- no missing BR
- no unnecessary BR
- no locales
- not relocatable
- owns all directories that it creates
- no duplicate files
- permissions ok
- %clean ok
- macro use consistent
- code, not content
- no need for -docs
- nothing in %doc affects runtime
- no need for .desktop file

Bad:

- Source does not match upstream:

md5sum upstream/fuse-0.7.0.tar.gz ../SOURCES/fuse-0.7.0.tar.gz
d81ad260cd6a8dd533af01ee6a5f9527  upstream/fuse-0.7.0.tar.gz
ebb124e808e6467630efaae01fe03b64  ../SOURCES/fuse-0.7.0.tar.gz

Show me a new SRPM with source that matches upstream, and I'll approve this.


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.