[Bug 170978] Review Request: nomadsync

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: nomadsync


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=170978





------- Additional Comments From mpeters at mac.com  2006-03-08 07:25 EST -------
Good:

* Builds fine in mock (fc4 i386)
* rpmlint clean
* owns all directories it installs
* proper rpm Group
* clean rpm spec file
* proper summary and description in American English
* spec file understabdable
* proper and consistent use of macros
* proper installation of Desktop file, with X-Fedora category and fedora vendor
* proper permissions on files

BAD
md5sum in src.rpm: f8d50c14fae3f8cdedc57c491c7d65d4 
../SOURCES/nomadsync-0.4.2.tar.gz
md5sum upstream: fd55927c54cd0737cdecb88e4bfbf0b7  nomadsync-0.4.2.tar.gz

-=-
looking at the two - nomadsync is upstream source unpacked, nomadsync-0.4.2.src
is from the src.rpm

[mpeters at jerusalem delete_me]$ diff -u nomadsync nomadsync-0.4.2.src
Only in nomadsync-0.4.2.src: Makefile
Only in nomadsync-0.4.2.src: config.log
Only in nomadsync-0.4.2.src: config.status
Common subdirectories: nomadsync/cvs and nomadsync-0.4.2.src/cvs
Common subdirectories: nomadsync/debug and nomadsync-0.4.2.src/debug
Common subdirectories: nomadsync/doc and nomadsync-0.4.2.src/doc
Only in nomadsync-0.4.2.src: libtool
Common subdirectories: nomadsync/macros and nomadsync-0.4.2.src/macros
Common subdirectories: nomadsync/optimized and nomadsync-0.4.2.src/optimized
Common subdirectories: nomadsync/src and nomadsync-0.4.2.src/src
Common subdirectories: nomadsync/templates and nomadsync-0.4.2.src/templates
[mpeters at jerusalem delete_me]$ 

It looks like the source tarball you have had configure run in it before it was
archived.

Use the pristine upstream source tarball.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.