[Bug 165314] Review Request: kismet -- A WLAN detector, sniffer and IDS

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: kismet -- A WLAN detector, sniffer and IDS


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=165314





------- Additional Comments From j.w.r.degoede at hhs.nl  2006-03-16 14:55 EST -------
(In reply to comment #15)
> > all the %global stuff is ugly
> 
> The %global is required because %define is buggy
> 

I wasn't talking about the use of %global vs %define, I was talking about the
version and release stuff, which is unnescesarry and very different from how the
rest of FE does it. You clearly have a different style and don't want to adapt 
(see curly braces discussion), since there is no hard required codingstyle for
FE like there is for the kernel I'll accept this, but I don't like it.
Now lets stop discussing this and focus on the stuff that matters.

> > so that one can see from the spec that this is a suid binary
> 
> ??? There should be no SUID binary in the 'kismet' package
> 

You're right I thought there was / would be because of the extra user now that
I've actually been able to build (and install) it my knowledge of kismet has
improved and much of the questions below have been answered already, non the
less thanks for the answer. 

> > Also why exactly does kismet need its own user?
> 
> See section 6, "Suidroot & Security" in the shipped README
> 

I already thougt as much.

> 
> > And whats with the gps being disabled with ./configure and then
> > packaged as -extras that doesn't make sense?
> 
> ??? My spec file states
> 
> | %configure --enable-ipv6 --sysconfdir=%cfgdir
> 
> GPS support won't be disabled there.
> 

My bad, gps support was disabled in a sed script not in the configure I now
understand the sed script only edits the default config file and does not impact
compilation.


> 
> > And why does kismet have /var/lib/kismet as homedir?
> 
> kismet stores information about found networks under ~/.kismet (see
> the 'configdir' variable in kismet.conf)
> 

Yes, thanks for the new spec much better. I do have one problem left I don't
like the /var/lib/kismet/.kismet and /var/lib/kismet/logs construction at all.

Since both the state (configdir configfile option) and the log directory can be
configured from the config file why not use:
/var/log/kismet for the logs
and:
/var/lib/kismet for the state (thus without the .kismet behind it)

Thats much cleaner IMHO. If we can get that one sorted out I'll do a full review
soon.


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.