[Bug 185721] Review Request: yadex - Doom level/wad editor

bugzilla at redhat.com bugzilla at redhat.com
Sat Mar 18 09:07:25 UTC 2006


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: yadex - Doom level/wad editor


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=185721





------- Additional Comments From j.w.r.degoede at hhs.nl  2006-03-18 04:07 EST -------
I thought it would be a good idea to start the full review while waiting for an
updated version with my patch included. This review is done with my patch
included, otherwise I wouldn't ger very far.


MUST
====
* rpmlint output clean
* Package named correctly
* GPL license OK.
* spec file legible, in Am. English
* Source matches upstream
* Successfully compiles and builds on at least one platform (FC-5 x86_64)
* no locale data, shared libraries, or static libraries
* No excessive Requires: or BR:
* Summary and description ok
* macro use consistent
* package owns the directories that it creates.
* Not relocatable
* %doc does not affect runtime

MUSTFIX
=======
* Does not compile on FC-5 without the attached patch


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.




More information about the fedora-extras-list mailing list